2.x: Add doAfterTerminate callback to the Single type. #5093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
reviewed
Feb 12, 2017
| * @return a Single that emits the same items as the source Single, then invokes the | ||
| * {@link Action} | ||
| * @see <a href="http://reactivex.io/documentation/operators/do.html">ReactiveX operators documentation: Do</a> | ||
| */ |
There was a problem hiding this comment.
Looks good, please add @since 2.0.6 - experimental to the javadoc.
akarnokd
reviewed
Feb 12, 2017
| /** | ||
| * Calls an action after pushing the current item or an error to the downstream. | ||
| * @param <T> the value type | ||
| */ |
There was a problem hiding this comment.
Please add @since 2.0.6 - experimental here as well. No need for the @Experimental annotation.
Codecov Report
@@ Coverage Diff @@
## 2.x #5093 +/- ##
============================================
+ Coverage 95.52% 95.64% +0.11%
- Complexity 5548 5557 +9
============================================
Files 614 615 +1
Lines 39651 39682 +31
Branches 5577 5578 +1
============================================
+ Hits 37877 37954 +77
+ Misses 778 745 -33
+ Partials 996 983 -13
Continue to review full report at Codecov.
|
akarnokd
approved these changes
Feb 12, 2017
akarnokd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in THIS StackOverflow question, doAfterTerminate() is currently missing in RxJava2. There's no strong reason for that, so this PR adds support for it.